From 061010288a99fd11f91bf713ac68068c57f79be7 Mon Sep 17 00:00:00 2001
From: archshift <admin@archshift.com>
Date: Mon, 14 Jul 2014 13:46:15 -0700
Subject: Readability and clarity changes

---
 src/Items/ItemPotion.h | 75 ++++++++++++++++++++++++++++++--------------------
 1 file changed, 45 insertions(+), 30 deletions(-)

(limited to 'src/Items/ItemPotion.h')

diff --git a/src/Items/ItemPotion.h b/src/Items/ItemPotion.h
index 5badeda94..b72499431 100644
--- a/src/Items/ItemPotion.h
+++ b/src/Items/ItemPotion.h
@@ -11,33 +11,35 @@ class cItemPotionHandler:
 	
 	int GetPotionName(short a_ItemDamage)
 	{
-		return a_ItemDamage & 63;
+		// First six bits (least significant)
+		return a_ItemDamage & 0x3F;
 	}
 	
 	cEntityEffect::eType GetEntityEffectType(short a_ItemDamage)
 	{
+		// First four bits (least significant)
 		// Potion effect bits are different from entity effect values
 		// For reference: http://minecraft.gamepedia.com/Data_values#.22Potion_effect.22_bits
-		switch (a_ItemDamage & 15)
+		switch (a_ItemDamage & 0xF)
 		{
-			case 1:  return cEntityEffect::effRegeneration;
-			case 2:  return cEntityEffect::effSpeed;
-			case 3:  return cEntityEffect::effFireResistance;
-			case 4:  return cEntityEffect::effPoison;
-			case 5:  return cEntityEffect::effInstantHealth;
-			case 6:  return cEntityEffect::effNightVision;
-			case 8:  return cEntityEffect::effWeakness;
-			case 9:  return cEntityEffect::effStrength;
-			case 10: return cEntityEffect::effSlowness;
-			case 12: return cEntityEffect::effInstantDamage;
-			case 13: return cEntityEffect::effWaterBreathing;
-			case 14: return cEntityEffect::effInvisibility;
+			case 0x1: return cEntityEffect::effRegeneration;
+			case 0x2: return cEntityEffect::effSpeed;
+			case 0x3: return cEntityEffect::effFireResistance;
+			case 0x4: return cEntityEffect::effPoison;
+			case 0x5: return cEntityEffect::effInstantHealth;
+			case 0x6: return cEntityEffect::effNightVision;
+			case 0x8: return cEntityEffect::effWeakness;
+			case 0x9: return cEntityEffect::effStrength;
+			case 0xA: return cEntityEffect::effSlowness;
+			case 0xC: return cEntityEffect::effInstantDamage;
+			case 0xD: return cEntityEffect::effWaterBreathing;
+			case 0xE: return cEntityEffect::effInvisibility;
 			
 			// No effect potions
-			case 0:
-			case 7:
-			case 11:
-			case 15:
+			case 0x0:
+			case 0x7:
+			case 0xB: // Will be potion of leaping in 1.8
+			case 0xF:
 			{
 				break;
 			}
@@ -48,9 +50,8 @@ class cItemPotionHandler:
 	
 	short GetEntityEffectIntensity(short a_ItemDamage)
 	{
-		// Level II potion if fifth bit is set
-		if (a_ItemDamage & 32) return 1;
-		else                   return 0;
+		// Level II potion if fifth bit (from zero) is set
+		return (a_ItemDamage & 0x20) ? 1 : 0;
 	}
 	
 	int GetEntityEffectDuration(short a_ItemDamage)
@@ -91,8 +92,8 @@ class cItemPotionHandler:
 		TierCoeff = (GetEntityEffectIntensity(a_ItemDamage) > 0) ? 0.5 : 1;
 		
 		// If potion is extended, multiply duration by 8/3. If not, stays the same
-		// Extended potion if sixth bit is set
-		ExtCoeff = (a_ItemDamage & 64) ? (8.0/3.0) : 1;
+		// Extended potion if sixth bit (from zero) is set
+		ExtCoeff = (a_ItemDamage & 0x40) ? (8.0/3.0) : 1;
 		
 		// If potion is splash potion, multiply duration by 3/4. If not, stays the same
 		SplashCoeff = IsDrinkable(a_ItemDamage) ? 1 : 0.75;
@@ -112,18 +113,26 @@ public:
 	
 	virtual bool IsDrinkable(short a_ItemDamage) override
 	{
-		// Drinkable potion if 13th bit is set
+		// Drinkable potion if 13th bit (from zero) is set
 		// For reference: http://minecraft.gamepedia.com/Potions#Data_value_table
-		return ((a_ItemDamage & 8192) != 0);
+		return ((a_ItemDamage & 0x2000) != 0);
 	}
 	
 	virtual bool OnItemUse(cWorld * a_World, cPlayer * a_Player, const cItem & a_Item, int a_BlockX, int a_BlockY, int a_BlockZ, eBlockFace a_Dir) override
 	{
+		short PotionDamage = a_Item.m_ItemDamage;
+		
+		// Only called when potion is a splash potion
+		if (IsDrinkable(PotionDamage))
+		{
+			return false;
+		}
+		
 		Vector3d Pos = a_Player->GetThrowStartPos();
 		Vector3d Speed = a_Player->GetLookVector() * 7;
 		
-		short potion_damage = a_Item.m_ItemDamage;
-		cSplashPotionEntity *Projectile = new cSplashPotionEntity(a_Player, Pos.x, Pos.y, Pos.z, &Speed, GetEntityEffectType(potion_damage), cEntityEffect(GetEntityEffectDuration(potion_damage), GetEntityEffectIntensity(potion_damage)), GetPotionName(potion_damage));
+		cSplashPotionEntity *Projectile = new cSplashPotionEntity(a_Player, Pos.x, Pos.y, Pos.z, &Speed, GetEntityEffectType(PotionDamage), cEntityEffect(GetEntityEffectDuration(PotionDamage), GetEntityEffectIntensity(PotionDamage)), GetPotionName(PotionDamage));
+		
 		if (Projectile == NULL)
 		{
 			return false;
@@ -139,14 +148,20 @@ public:
 			a_Player->GetInventory().RemoveOneEquippedItem();
 		}
 		
-		// Called when potion is a splash potion
 		return true;
 	}
 	
 	virtual bool EatItem(cPlayer * a_Player, cItem * a_Item) override
 	{
-		// Called when potion is a drinkable potion
-		a_Player->AddEntityEffect(GetEntityEffectType(a_Item->m_ItemDamage), GetEntityEffectDuration(a_Item->m_ItemDamage), GetEntityEffectIntensity(a_Item->m_ItemDamage));
+		short PotionDamage = a_Item->m_ItemDamage;
+		
+		// Only called when potion is a drinkable potion
+		if (!IsDrinkable(a_Item->m_ItemDamage))
+		{
+			return false;
+		}
+		
+		a_Player->AddEntityEffect(GetEntityEffectType(PotionDamage), GetEntityEffectDuration(PotionDamage), GetEntityEffectIntensity(PotionDamage));
 		a_Player->GetInventory().RemoveOneEquippedItem();
 		a_Player->GetInventory().AddItem(E_ITEM_GLASS_BOTTLE);
 		return true;
-- 
cgit v1.2.3