From 4b81d19a1a4f3edd09a5e83d0ceae43462cb4ef1 Mon Sep 17 00:00:00 2001 From: Fernando Sahmkow Date: Thu, 19 Sep 2019 20:56:29 -0400 Subject: Shader_IR: Implement ICMP. --- .../shader/decode/arithmetic_integer.cpp | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) (limited to 'src/video_core/shader') diff --git a/src/video_core/shader/decode/arithmetic_integer.cpp b/src/video_core/shader/decode/arithmetic_integer.cpp index c8c1a7f40..1aa21010a 100644 --- a/src/video_core/shader/decode/arithmetic_integer.cpp +++ b/src/video_core/shader/decode/arithmetic_integer.cpp @@ -138,6 +138,32 @@ u32 ShaderIR::DecodeArithmeticInteger(NodeBlock& bb, u32 pc) { SetRegister(bb, instr.gpr0, value); break; } + case OpCode::Id::ICMP_CR: + case OpCode::Id::ICMP_R: + case OpCode::Id::ICMP_RC: { + UNIMPLEMENTED_IF(instr.icmp.is_signed != 0); + const Node zero = Immediate(0); + + const auto [op_a, op_b] = [&]() -> std::tuple { + switch (opcode->get().GetId()) { + case OpCode::Id::ICMP_CR: + return {GetConstBuffer(instr.cbuf34.index, instr.cbuf34.offset), + GetRegister(instr.gpr39)}; + case OpCode::Id::ICMP_R: + return {GetRegister(instr.gpr20), GetRegister(instr.gpr39)}; + case OpCode::Id::ICMP_RC: + return {GetRegister(instr.gpr39), + GetConstBuffer(instr.cbuf34.index, instr.cbuf34.offset)}; + default: + UNIMPLEMENTED(); + return {zero, zero}; + } + }(); + const Node test = GetRegister(instr.gpr8); + const Node comparison = GetPredicateComparisonInteger(instr.icmp.cond, false, test, zero); + SetRegister(bb, instr.gpr0, Operation(OperationCode::Select, comparison, op_a, op_b)); + break; + } case OpCode::Id::LOP_C: case OpCode::Id::LOP_R: case OpCode::Id::LOP_IMM: { -- cgit v1.2.3 From 527b841c1567fd7552153eea0fdcee119e44c53f Mon Sep 17 00:00:00 2001 From: Fernando Sahmkow Date: Fri, 20 Sep 2019 11:41:05 -0400 Subject: Shader_IR: ICMP corrections and fixes --- src/video_core/shader/decode/arithmetic_integer.cpp | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) (limited to 'src/video_core/shader') diff --git a/src/video_core/shader/decode/arithmetic_integer.cpp b/src/video_core/shader/decode/arithmetic_integer.cpp index 1aa21010a..b73f6536e 100644 --- a/src/video_core/shader/decode/arithmetic_integer.cpp +++ b/src/video_core/shader/decode/arithmetic_integer.cpp @@ -140,11 +140,11 @@ u32 ShaderIR::DecodeArithmeticInteger(NodeBlock& bb, u32 pc) { } case OpCode::Id::ICMP_CR: case OpCode::Id::ICMP_R: - case OpCode::Id::ICMP_RC: { - UNIMPLEMENTED_IF(instr.icmp.is_signed != 0); + case OpCode::Id::ICMP_RC: + case OpCode::Id::ICMP_IMM: { const Node zero = Immediate(0); - const auto [op_a, op_b] = [&]() -> std::tuple { + const auto [op_b, test] = [&]() -> std::pair { switch (opcode->get().GetId()) { case OpCode::Id::ICMP_CR: return {GetConstBuffer(instr.cbuf34.index, instr.cbuf34.offset), @@ -154,13 +154,16 @@ u32 ShaderIR::DecodeArithmeticInteger(NodeBlock& bb, u32 pc) { case OpCode::Id::ICMP_RC: return {GetRegister(instr.gpr39), GetConstBuffer(instr.cbuf34.index, instr.cbuf34.offset)}; + case OpCode::Id::ICMP_IMM: + return {Immediate(instr.alu.GetSignedImm20_20()), GetRegister(instr.gpr39)}; default: - UNIMPLEMENTED(); + UNREACHABLE(); return {zero, zero}; } }(); - const Node test = GetRegister(instr.gpr8); - const Node comparison = GetPredicateComparisonInteger(instr.icmp.cond, false, test, zero); + const Node op_a = GetRegister(instr.gpr8); + const Node comparison = + GetPredicateComparisonInteger(instr.icmp.cond, instr.icmp.is_signed != 0, test, zero); SetRegister(bb, instr.gpr0, Operation(OperationCode::Select, comparison, op_a, op_b)); break; } -- cgit v1.2.3