summaryrefslogtreecommitdiffstats
path: root/src/common
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2015-03-09 03:25:04 +0100
committerbunnei <bunneidev@gmail.com>2015-03-09 03:25:04 +0100
commitba8ce6c8f59f012cd22dbc76d26ba290d9174d60 (patch)
tree07bdfa055455654f2d1d74998137ea3b285a96a8 /src/common
parentMerge pull request #639 from archshift/appbundle (diff)
parentAsserts: Use lambdas to keep assertion code away from the main code path (diff)
downloadyuzu-ba8ce6c8f59f012cd22dbc76d26ba290d9174d60.tar
yuzu-ba8ce6c8f59f012cd22dbc76d26ba290d9174d60.tar.gz
yuzu-ba8ce6c8f59f012cd22dbc76d26ba290d9174d60.tar.bz2
yuzu-ba8ce6c8f59f012cd22dbc76d26ba290d9174d60.tar.lz
yuzu-ba8ce6c8f59f012cd22dbc76d26ba290d9174d60.tar.xz
yuzu-ba8ce6c8f59f012cd22dbc76d26ba290d9174d60.tar.zst
yuzu-ba8ce6c8f59f012cd22dbc76d26ba290d9174d60.zip
Diffstat (limited to 'src/common')
-rw-r--r--src/common/assert.h31
1 files changed, 25 insertions, 6 deletions
diff --git a/src/common/assert.h b/src/common/assert.h
index 3b2232a7e..9ca7adb15 100644
--- a/src/common/assert.h
+++ b/src/common/assert.h
@@ -4,24 +4,43 @@
#pragma once
+#include <cstdlib>
+
#include "common/common_funcs.h"
+// For asserts we'd like to keep all the junk executed when an assert happens away from the
+// important code in the function. One way of doing this is to put all the relevant code inside a
+// lambda and force the compiler to not inline it. Unfortunately, MSVC seems to have no syntax to
+// specify __declspec on lambda functions, so what we do instead is define a noinline wrapper
+// template that calls the lambda. This seems to generate an extra instruction at the call-site
+// compared to the ideal implementation (which wouldn't support ASSERT_MSG parameters), but is good
+// enough for our purposes.
+template <typename Fn>
+#if defined(_MSC_VER)
+ __declspec(noinline, noreturn)
+#elif defined(__GNUC__)
+ __attribute__((noinline, noreturn, cold))
+#endif
+static void assert_noinline_call(const Fn& fn) {
+ fn();
+ Crash();
+ exit(1); // Keeps GCC's mouth shut about this actually returning
+}
+
// TODO (yuriks) allow synchronous logging so we don't need printf
#define ASSERT(_a_) \
- do if (!(_a_)) {\
+ do if (!(_a_)) { assert_noinline_call([] { \
fprintf(stderr, "Assertion Failed!\n\n Line: %d\n File: %s\n Time: %s\n", \
__LINE__, __FILE__, __TIME__); \
- Crash(); \
- } while (0)
+ }); } while (0)
#define ASSERT_MSG(_a_, ...) \
- do if (!(_a_)) {\
+ do if (!(_a_)) { assert_noinline_call([&] { \
fprintf(stderr, "Assertion Failed!\n\n Line: %d\n File: %s\n Time: %s\n", \
__LINE__, __FILE__, __TIME__); \
fprintf(stderr, __VA_ARGS__); \
fprintf(stderr, "\n"); \
- Crash(); \
- } while (0)
+ }); } while (0)
#define UNREACHABLE() ASSERT_MSG(false, "Unreachable code!")