diff options
author | Subv <subv2112@gmail.com> | 2018-05-30 19:03:19 +0200 |
---|---|---|
committer | Subv <subv2112@gmail.com> | 2018-05-31 04:36:29 +0200 |
commit | 3957b0c34e3060277a182c9ade3f4b69c0b7061c (patch) | |
tree | e80eb1b2b9e911392bee510bd22639b4b18bfb39 /src | |
parent | Kernel/Thread: Corrected a typo in an assert about the processor id. (diff) | |
download | yuzu-3957b0c34e3060277a182c9ade3f4b69c0b7061c.tar yuzu-3957b0c34e3060277a182c9ade3f4b69c0b7061c.tar.gz yuzu-3957b0c34e3060277a182c9ade3f4b69c0b7061c.tar.bz2 yuzu-3957b0c34e3060277a182c9ade3f4b69c0b7061c.tar.lz yuzu-3957b0c34e3060277a182c9ade3f4b69c0b7061c.tar.xz yuzu-3957b0c34e3060277a182c9ade3f4b69c0b7061c.tar.zst yuzu-3957b0c34e3060277a182c9ade3f4b69c0b7061c.zip |
Diffstat (limited to 'src')
-rw-r--r-- | src/core/hle/kernel/errors.h | 2 | ||||
-rw-r--r-- | src/core/hle/kernel/svc.cpp | 27 |
2 files changed, 28 insertions, 1 deletions
diff --git a/src/core/hle/kernel/errors.h b/src/core/hle/kernel/errors.h index 5be20c878..e1b5430bf 100644 --- a/src/core/hle/kernel/errors.h +++ b/src/core/hle/kernel/errors.h @@ -21,7 +21,9 @@ enum { // Confirmed Switch OS error codes MisalignedAddress = 102, + InvalidProcessorId = 113, InvalidHandle = 114, + InvalidCombination = 116, Timeout = 117, SynchronizationCanceled = 118, TooLarge = 119, diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index 0811a16b8..ec3601e8b 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp @@ -732,7 +732,7 @@ static ResultCode GetThreadCoreMask(Handle thread_handle, u32* core, u64* mask) } static ResultCode SetThreadCoreMask(Handle thread_handle, u32 core, u64 mask) { - NGLOG_TRACE(Kernel_SVC, "called, handle=0x{:08X}, mask=0x{:08X}, core=0x{:X}", thread_handle, + NGLOG_DEBUG(Kernel_SVC, "called, handle=0x{:08X}, mask=0x{:16X}, core=0x{:X}", thread_handle, mask, core); const SharedPtr<Thread> thread = g_handle_table.Get<Thread>(thread_handle); @@ -740,6 +740,31 @@ static ResultCode SetThreadCoreMask(Handle thread_handle, u32 core, u64 mask) { return ERR_INVALID_HANDLE; } + if (core == THREADPROCESSORID_DEFAULT) { + ASSERT(thread->owner_process->ideal_processor != THREADPROCESSORID_DEFAULT); + // Set the target CPU to the one specified in the process' exheader. + core = thread->owner_process->ideal_processor; + mask = 1 << core; + } + + if (mask == 0) { + return ResultCode(ErrorModule::Kernel, ErrCodes::InvalidCombination); + } + + /// This value is used to only change the affinity mask without changing the current ideal core. + static constexpr u32 OnlyChangeMask = static_cast<u32>(-3); + + if (core == OnlyChangeMask) { + core = thread->ideal_core; + } else if (core >= Core::NUM_CPU_CORES && core != -1) { + return ResultCode(ErrorModule::Kernel, ErrCodes::InvalidProcessorId); + } + + // Error out if the input core isn't enabled in the input mask. + if (core < Core::NUM_CPU_CORES && (mask & (1 << core)) == 0) { + return ResultCode(ErrorModule::Kernel, ErrCodes::InvalidCombination); + } + thread->ChangeCore(core, mask); return RESULT_SUCCESS; |